Skip to content

Update ezgl to use submodules #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Update ezgl to use submodules #3124

merged 2 commits into from
Jun 10, 2025

Conversation

AmirhosseinPoolad
Copy link
Contributor

This PR is the first step in trying to move our internally owned external libraries such as ezgl and tatum to use submodules instead of subtrees since we want these libraries to stay in sync and apply all changes to their own repository and not have many/any downstream patches in the VTR repository.

The code currently compiles but is not tested.

@github-actions github-actions bot added lang-cpp C/C++ code lang-make CMake/Make code external_libs labels Jun 9, 2025
@SamuelHo10
Copy link
Contributor

SamuelHo10 commented Jun 9, 2025

I've tested the GUI and verified that the documentation is being built correctly. I think this PR is ready to merge.

@AmirhosseinPoolad AmirhosseinPoolad changed the title [WIP] Update ezgl to use submodules Update ezgl to use submodules Jun 9, 2025
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it was tested well.

@AlexandreSinger
Copy link
Contributor

Whats great about this is that now it should be tracked by Dependabot, so we should always have the most up-to-date EZGL documentation.

@SamuelHo10 Do be sure to write down the steps you took to verify the GUI. We will need to perform those steps every time we update EZGL versions on VTR. EZGL does not change much, but its good to be safe.

@AlexandreSinger AlexandreSinger merged commit 3b984a7 into master Jun 10, 2025
32 checks passed
@AlexandreSinger AlexandreSinger deleted the ezgl_update branch June 10, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external_libs lang-cpp C/C++ code lang-make CMake/Make code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants