-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.19.1]: Temporarily work around deploy build command issue #2292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please share more information on how to reproduce this issue?
It worries me a bit that the parent path did not exist. I would like to ensure that the solution does not cover a bug.
In order to reproduce; A) create a new service (Note, this is to show the bug and can be done in any other repo with a service);
B) try to deploy that service;
|
An update regarding your PR:
Please bear with us while we investigate the above situation. |
coolio any idea when this will be resolved, is blocking us haha That timing out out issue seems quite nasty to be honest. You can specifically see its a cancelled job as well. |
Releasing this to unblock you. Will address the issues in #2292 (comment) in the next release. |
Thank you alot ser |
The deployment build process requires the directories. This commit properly fixes the issue that was worked around in #2292 and rolled back in 5e41dd7b0582933c16ec2a68ffbc35100e34d0d4.
Proposed changes
Resolves issue with path directory when using default build commands.