Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove continue-on-error so the default applies #2303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Adamantios
Copy link
Collaborator

Proposed changes

The default value for the continue-on-error flag is false. Because the flag was set to true for the unit tests, a green status was being reported despite them failing due to an infinite loop introduced in the dev mode in #2221. As a result, the failure went unnoticed for 5 months, which eventually led to additional bugs in the CLI, since its tests appeared to pass.

This issue was first mentioned in #2292 (comment).

Fixes

n/a

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

n/a

The default value for the `continue-on-error` flag is `false`. Because the flag was set to `true` for the unit tests, a green status was being reported despite them failing due to an infinite loop introduced in the dev mode in #2221. As a result, the failure went unnoticed for 5 months, which eventually led to additional bugs in the CLI, since its tests appeared to pass.
Copy link
Member

@OjusWiZard OjusWiZard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Adamantios Adamantios mentioned this pull request Feb 12, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants