refactor!: rename contentWidth and contentHeight to width and height #9631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Jul 4, 2025
web-padawan
force-pushed
the
refactor/popover-width-height
branch
from
fe232e1 to
1b9cafd
Compare
web-padawan
force-pushed
the
refactor/popover-width-height
branch
from
1b9cafd to
bc50487
Compare
DiegoCardoso
approved these changes
Jul 4, 2025
|
vursen
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #9453
Updated
vaadin-popoverto usewidthandheightfor consistency withvaadin-dialogandvaadin-confirm-dialog.Type of change