chore: update overlay tests and Popover dev page #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix-popover-dev-page
branch
from
e90cf65 to
ea1c7ed
Compare
sissbruecker
changed the title
|
Also fixed Popover and Select tests to not query content from the overlay element. |
sissbruecker
approved these changes
Jul 24, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed to use
widthandheight, see following PRs:Using
nullis needed for now, as empty string isn't handled and therefore doesn't reset width / height.This needs to be fixed in the web component, it likely also affects Dialog and ConfirmDialog.
Type of change