-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ansible add directory UI layout #9877
base: master
Are you sure you want to change the base?
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9877/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
@@ -221,7 +221,8 @@ export class AnsibleControlNode extends React.Component<PropsType, StateType> { | |||
<NewAnsiblePath | |||
title={t("Add an Inventory file")} | |||
pathType="inventory" | |||
newInventoryPath={this.state.newInventoryPath} | |||
// TODO: @parlt91: Is this bugfix correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parlt91 I added missing types to NewAnsiblePath
and found that this prop was not actually connected to anything. I'm guessing it should be the change I made, but I'm not sure and don't know how to test, can you please confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this is definitely how it should be. This is setting the TextField
s value
prop, but since it's always empty to begin with and not used anywhere it didn't actually cause any issues. I'd still keep your fix in place though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -221,7 +221,8 @@ export class AnsibleControlNode extends React.Component<PropsType, StateType> { | |||
<NewAnsiblePath | |||
title={t("Add an Inventory file")} | |||
pathType="inventory" | |||
newInventoryPath={this.state.newInventoryPath} | |||
// TODO: @parlt91: Is this bugfix correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this is definitely how it should be. This is setting the TextField
s value
prop, but since it's always empty to begin with and not used anywhere it didn't actually cause any issues. I'd still keep your fix in place though.
What does this PR change?
This is not the nicest fix, ideally we'd fix the global styles that affect this, but that would mean breaking many other things. For now, this fix applies only here and resolves the problem.
GUI diff
After:
Documentation
No documentation needed: layout bugfix
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: layout bugfix
DONE
Links
Fixes https://github.com/SUSE/spacewalk/issues/26555
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!