Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ansible add directory UI layout #9877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Etheryte
Copy link
Member

@Etheryte Etheryte commented Mar 3, 2025

What does this PR change?

This is not the nicest fix, ideally we'd fix the global styles that affect this, but that would mean breaking many other things. For now, this fix applies only here and resolves the problem.

GUI diff

After:

Screenshot 2025-03-03 at 11 48 54
  • DONE

Documentation

  • No documentation needed: layout bugfix

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: layout bugfix

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/26555

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

github-actions bot commented Mar 3, 2025

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9877/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9877/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@Etheryte Etheryte marked this pull request as ready for review March 3, 2025 10:55
@Etheryte Etheryte requested a review from a team as a code owner March 3, 2025 10:55
@@ -221,7 +221,8 @@ export class AnsibleControlNode extends React.Component<PropsType, StateType> {
<NewAnsiblePath
title={t("Add an Inventory file")}
pathType="inventory"
newInventoryPath={this.state.newInventoryPath}
// TODO: @parlt91: Is this bugfix correct?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parlt91 I added missing types to NewAnsiblePath and found that this prop was not actually connected to anything. I'm guessing it should be the change I made, but I'm not sure and don't know how to test, can you please confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this is definitely how it should be. This is setting the TextFields value prop, but since it's always empty to begin with and not used anywhere it didn't actually cause any issues. I'd still keep your fix in place though.

@Etheryte Etheryte requested a review from parlt91 March 3, 2025 10:57
Copy link
Contributor

@parlt91 parlt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -221,7 +221,8 @@ export class AnsibleControlNode extends React.Component<PropsType, StateType> {
<NewAnsiblePath
title={t("Add an Inventory file")}
pathType="inventory"
newInventoryPath={this.state.newInventoryPath}
// TODO: @parlt91: Is this bugfix correct?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this is definitely how it should be. This is setting the TextFields value prop, but since it's always empty to begin with and not used anywhere it didn't actually cause any issues. I'd still keep your fix in place though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants