Fix Ansible add directory UI layout

uyuni-project · Mar 3, 2025 · 3f28fd9 · 3f28fd9
1 parent 774aab5
commit 3f28fd9
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 16 deletions.
diff --git a/web/html/src/manager/minion/ansible/ansible-control-node.tsx b/web/html/src/manager/minion/ansible/ansible-control-node.tsx
@@ -221,7 +221,8 @@ export class AnsibleControlNode extends React.Component<PropsType, StateType> {
                 <NewAnsiblePath
                   title={t("Add an Inventory file")}
                   pathType="inventory"
-                  newInventoryPath={this.state.newInventoryPath}
+                  // TODO: @parlt91: Is this bugfix correct?
+                  newPathValue={this.state.newInventoryPath}
                   placeholder={t("e.g., /etc/ansible/testing/hosts")}
                   newPath={(path: string) => this.newPath("inventory", path)}
                   savePath={() => this.savePath("inventory")}

diff --git a/web/html/src/manager/minion/ansible/new-ansible-path.tsx b/web/html/src/manager/minion/ansible/new-ansible-path.tsx
@@ -3,26 +3,39 @@ import * as React from "react";
 import { AsyncButton } from "components/buttons";
 import { TextField } from "components/fields";
 
-const NewAnsiblePath = (props) => {
+type Props = {
+  title: string;
+  pathType: string;
+  newPathValue: string;
+  newPath: (value: string) => any;
+  placeholder?: string;
+  savePath: (...args: any) => any;
+};
+
+const NewAnsiblePath = (props: Props) => {
   return (
     <>
       <h4>{props.title}</h4>
       <div className="form-group">
-        <TextField
-          id={"new_" + props.pathType + "_path_input"}
-          placeholder={props.placeholder}
-          value={props.newPathValue}
-          onChange={(e: any) => props.newPath(e.target.value.toString())}
-        />
+        <div>
+          <TextField
+            id={"new_" + props.pathType + "_path_input"}
+            placeholder={props.placeholder}
+            value={props.newPathValue}
+            onChange={(e: any) => props.newPath(e.target.value.toString())}
+          />
+        </div>
       </div>
-      <div className="pull-right btn-group">
-        <AsyncButton
-          id={"new_" + props.pathType + "_path_save"}
-          action={props.savePath}
-          defaultType="btn-primary"
-          text={t("Save")}
-          icon="fa-save"
-        />
+      <div className="d-flex justify-content-end">
+        <div className="btn-group">
+          <AsyncButton
+            id={"new_" + props.pathType + "_path_save"}
+            action={props.savePath}
+            defaultType="btn-primary"
+            text={t("Save")}
+            icon="fa-save"
+          />
+        </div>
       </div>
     </>
   );

diff --git a/web/spacewalk-web.changes.eth.ans b/web/spacewalk-web.changes.eth.ans
@@ -0,0 +1 @@
+- Fix layout issues on Ansible pages