chore: clippy::redundant_closure_for_method_calls

[nyurik]

• clippy::redundant_closure_for_method_calls

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing nyurik:redundant_closure_for_method_calls (6dafdbc) with main (398e4ba)}

Summary

✅ 284 untouched benchmarks
⏩ 38 skipped benchmarks¹

Footnotes

1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[nyurik]

thx @xtqqczze, makes sense, fixed

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[xtqqczze]

thx @xtqqczze, makes sense, fixed

There's a lot of other cases we could use ToOwned::to_owned etc

[nyurik]

instead of to_string? I would generally agree, but this is not something we should spend too much time on - perhaps we can write a new clippy lint that uses some heuristic to determine which clone / to_string / to_owned variant should be used.

[xtqqczze]

Good news: the str_to_string lint already covers exactly this case, so we can address it later.

[xtqqczze]

Good news: the str_to_string lint already covers exactly this case, so we can address it later.

Unfortunately, it doesn't trigger when the method is referenced directly, see rust-lang/rust-clippy#16511

[xtqqczze]

@nyurik should we address str_to_string first in a new PR to avoid missing the cases once this lint is applied?

[nyurik]

@xtqqczze addressed in rust-lang/rust-clippy#16512 - I think this is a better way to catch everything :)

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

[xtqqczze]

@xtqqczze addressed in rust-lang/rust-clippy#16512 - I think this is a better way to catch everything :)

@nyurik OK, since CI needs to run again anyway, let's revert the changes from 6dafdbc and then address them systematically in a new PR.