Skip to content

clippy: fix str_to_string lint#10745

Draft
xtqqczze wants to merge 3 commits intouutils:mainfrom
xtqqczze:clippy/str_to_string
Draft

clippy: fix str_to_string lint#10745
xtqqczze wants to merge 3 commits intouutils:mainfrom
xtqqczze:clippy/str_to_string

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 5, 2026

@xtqqczze xtqqczze force-pushed the clippy/str_to_string branch from 092c8bb to 10531b9 Compare February 5, 2026 17:14
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.

@xtqqczze xtqqczze force-pushed the clippy/str_to_string branch from 10531b9 to b4213cf Compare February 5, 2026 17:50
@xtqqczze xtqqczze marked this pull request as draft February 5, 2026 18:04
@xtqqczze xtqqczze force-pushed the clippy/str_to_string branch 2 times, most recently from 2b0391c to e77a1fa Compare February 5, 2026 19:50
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@xtqqczze xtqqczze force-pushed the clippy/str_to_string branch 5 times, most recently from 9a6f51d to b13e432 Compare February 5, 2026 20:54
@nyurik
Copy link
Contributor

nyurik commented Feb 5, 2026

just fyi - i tried running it from my local clippy clone (on main) -- cargo dev lint <full-path-to-coreutils> -- --fix --allow-dirty --workspace --all-features after adding str_to_string = "warn" to Cargo.toml - tons of changes. Note that I ran it on top of my other PR, so your changes might be different. That said, I think it is better to merge #10704 first - otherwise it will have tons of conflicts, and my PR already had tons of manual work, whereas running the above fix command would do it automatically.

@xtqqczze xtqqczze force-pushed the clippy/str_to_string branch from b13e432 to f33e12d Compare February 5, 2026 21:50
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 5, 2026

Merging this PR will not alter performance

✅ 284 untouched benchmarks
⏩ 38 skipped benchmarks1


Comparing xtqqczze:clippy/str_to_string (f33e12d) with main (398e4ba)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants