-
Notifications
You must be signed in to change notification settings - Fork 454
ci: remove toolchain adjustments #2484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+515
−628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0746bd5
to
ceb3747
Compare
…and container ci: add github.workspace prefix to cache path, so that artifacts created within the container run can be cached ci: fix artifact name ci: remove unnecessary step
ceb3747
to
a84c626
Compare
evilrobot-01
commented
Apr 23, 2025
Branch name may contain /, breaking file names.
…-contract-sizes job
# Conflicts: # CHANGELOG.md
davidsemakula
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks @evilrobot-01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2458
cargo-contract
orpallet-revive
?Updates CI workflow to use a new Docker image (use-ink/docker-images#4) with some image optimisations, along with updates to the scripts which were removing toolchains defined in the CI image to free up space.
Requires use-ink/docker-images#4 to be merged and a new CI docker image to be built/published.
Description
The PR introduces two new reusable actions:
.github/init
for intializing a runner in each job and.github/run-container-command
) for executing a batch of commands within a container.Each job runs in its own runner instance and therefore needs to have space cleared and caching setup. The
init
action standardises this approach in a somewhat configurable/flexible way. About 45GB is available after using theinit
action. Removing data does take a little time, so it should therefore only be used on jobs which actually require the space. The improveduseink/ci
image is 1.32GB compressed/~4.3GB uncompressed, leaving ~40GB free for jobs. All toolchain removals, CARGO_INCREMENTAL and partitioning has been removed as a result. The action also optionally sets up Rust caching, mostly so this is defined once and it is clear that it is per runner/job. Additional caching by matrix value is possible.The
run-container-command
action allows commands to be run within a container AFTER space has been cleared, which is important as the same runner disk is used for both the job, the pulled docker image and then the results of the job within the container. Using thecontainer
attribute sadly does not allow for space to be cleared prior to the container being launched, necessitating this action. The workspace on the host is mapped into a different path in the container, requiring a few adjustments to the directory paths for effective caching.Notes:
Checklist before requesting a review
CHANGELOG.md