build: optimize dockerfile #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilrobot-01
commented
Apr 21, 2025
| rm resolc.tar.gz && \ | ||
| chmod +x resolc-x86_64-unknown-linux-musl && \ | ||
| mv resolc-x86_64-unknown-linux-musl /usr/local/bin/resolc | ||
| if [ "$TARGETARCH" = "amd64" ]; then \ |
There was a problem hiding this comment.
Ideally revive should provide an arm64 binary for usage within Docker on apple silicon. Simply ignored on non-amd64 platforms for now, which should only affect ink integration tests when built on a Mac AFAIK.
An issue can be opened on revive to add Linux arm64 builds so that it can be used within containers on a Mac.
evilrobot-01
had a problem deploying
to
master_and_tags
GitHub Actions
Failure
evilrobot-01
force-pushed
the
frank/optimise-image
branch
from
aabde27 to
a4b2a16
Compare
4 tasks
Updates the `ci` Dockerfile to: - use the latest stable version of Rust (1.86) - standardise on a single version of nightly - use stable2503 release branch of the Polkadot SDK - allow (mostly) building on ARM platforms - split rustup and cargo install into separate layers for easier disk usage analysis - perform cleanup on each layer - use updated url for cargo-contract - merge the codecov tasks into a single layer
evilrobot-01
force-pushed
the
frank/optimise-image
branch
from
a4b2a16 to
7e33256
Compare
evilrobot-01
commented
Apr 23, 2025
evilrobot-01
commented
Apr 23, 2025
evilrobot-01
commented
Apr 23, 2025
evilrobot-01
commented
Apr 23, 2025
evilrobot-01
commented
Apr 23, 2025
evilrobot-01
commented
Apr 23, 2025
| git clone https://github.com/paritytech/polkadot-sdk.git --depth 50 && \ | ||
| cargo install --git https://github.com/use-ink/ink-node --branch main --force --locked && \ | ||
| cargo install --git https://github.com/use-ink/cargo-contract --locked --branch master && \ | ||
| git clone https://github.com/paritytech/polkadot-sdk.git -b ${POLKADOT_SDK_BRANCH} --depth 1 && \ |
There was a problem hiding this comment.
A faster approach is to download from a GitHub source code archive at a specific commit and decompress. As these images are generated rarely, not sure its worth the effort.
evilrobot-01
commented
Apr 23, 2025
| cargo install --git https://github.com/paritytech/cargo-contract \ | ||
| --locked --branch master && \ | ||
| git clone https://github.com/paritytech/polkadot-sdk.git --depth 50 && \ | ||
| cargo install --git https://github.com/use-ink/ink-node --branch main --force --locked && \ |
There was a problem hiding this comment.
Could be replaced with 'latest' prebuilt ink-node and cargo-contract binaries to speed things up.
evilrobot-01
commented
Apr 23, 2025
evilrobot-01
commented
Apr 23, 2025
davidsemakula
approved these changes
Apr 23, 2025
Co-authored-by: David Semakula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
ciDockerfile to:stableas the default toolchainNote:
Comments have been left as a guide.