Skip to content

fix(turbopack): keep the original sourcemap after source transform #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions turbopack/crates/turbopack-css/src/asset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use turbopack_core::{
reference_type::ImportContext,
resolve::origin::ResolveOrigin,
source::Source,
source_map::GenerateSourceMap,
};

use crate::{
Expand Down Expand Up @@ -96,14 +97,24 @@ impl ProcessCss for CssModuleAsset {
}

#[turbo_tasks::function]
fn finalize_css(
async fn finalize_css(
self: Vc<Self>,
chunking_context: Vc<Box<dyn ChunkingContext>>,
minify_type: MinifyType,
) -> Vc<FinalCssResult> {
) -> Result<Vc<FinalCssResult>> {
let process_result = self.get_css_with_placeholder();

finalize_css(process_result, chunking_context, minify_type)
let origin_source_map =
match ResolvedVc::try_sidecast::<Box<dyn GenerateSourceMap>>(self.await?.source) {
Some(gsm) => gsm.generate_source_map(),
None => Vc::cell(None),
};
Ok(finalize_css(
process_result,
chunking_context,
minify_type,
origin_source_map,
))
}
}

Expand Down
28 changes: 24 additions & 4 deletions turbopack/crates/turbopack-css/src/process.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ impl StyleSheetLike<'_, '_> {
minify_type: MinifyType,
enable_srcmap: bool,
handle_nesting: bool,
mut origin_source_map: Option<parcel_sourcemap::SourceMap>,
) -> Result<CssOutput> {
let ss = &self.0;
let mut srcmap = if enable_srcmap {
Expand Down Expand Up @@ -94,8 +95,12 @@ impl StyleSheetLike<'_, '_> {
if let Some(srcmap) = &mut srcmap {
debug_assert_eq!(ss.sources.len(), 1);

srcmap.add_sources(ss.sources.clone());
srcmap.set_source_content(0, code)?;
if let Some(origin_source_map) = origin_source_map.as_mut() {
let _ = srcmap.extends(origin_source_map);
} else {
srcmap.add_sources(ss.sources.clone());
srcmap.set_source_content(0, code)?;
}
}

let srcmap = match srcmap {
Expand Down Expand Up @@ -192,7 +197,7 @@ pub async fn process_css_with_placeholder(

// We use NoMinify because this is not a final css. We need to replace url references,
// and we do final codegen with proper minification.
let (result, _) = stylesheet.to_css(&code, MinifyType::NoMinify, false, false)?;
let (result, _) = stylesheet.to_css(&code, MinifyType::NoMinify, false, false, None)?;

let exports = result.exports.map(|exports| {
let mut exports = exports.into_iter().collect::<FxIndexMap<_, _>>();
Expand Down Expand Up @@ -221,6 +226,7 @@ pub async fn finalize_css(
result: Vc<CssWithPlaceholderResult>,
chunking_context: Vc<Box<dyn ChunkingContext>>,
minify_type: MinifyType,
origin_source_map: Vc<OptionStringifiedSourceMap>,
) -> Result<Vc<FinalCssResult>> {
let result = result.await?;
match &*result {
Expand Down Expand Up @@ -258,7 +264,21 @@ pub async fn finalize_css(
FileContent::Content(v) => v.content().to_str()?,
_ => bail!("this case should be filtered out while parsing"),
};
let (result, srcmap) = stylesheet.to_css(&code, minify_type, true, true)?;

let origin_source_map = origin_source_map.await?.as_ref().map(|rope| rope.clone());

let origin_source_map = origin_source_map.as_ref().and_then(|rope| {
rope.to_str().ok().and_then(|cow| {
if cow.is_empty() {
None
} else {
parcel_sourcemap::SourceMap::from_json("", &cow).ok()
}
})
});

let (result, srcmap) =
stylesheet.to_css(&code, minify_type, true, true, origin_source_map)?;

Ok(FinalCssResult::Ok {
output_code: result.code,
Expand Down
Loading