fix(turbopack): keep the original sourcemap after source transform #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xusd320
force-pushed
the
fix/css-sourcemap-after-transform
branch
from
0ea664f to
c5de6fd
Compare
|
PR to upstream: vercel#79700 |
xusd320
force-pushed
the
fix/css-sourcemap-after-transform
branch
from
c5de6fd to
987f9f5
Compare
fireairforce
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The original sourcemap be lost after source transform. For example, a
xyz.sassfile processed by sass-loader, return axyz.sass.css, the output css chunk only contains the sourcemap ofxyz.sass.cssproduced by lightningcss,xyz.sassassociated sourcemap been lost.How
Extend with the original sourcemap, see:
https://github.com/parcel-bundler/lightningcss/blob/f2dc67c4d3fe92f26693c02366db1e60cae0db27/napi/src/lib.rs#L776
PR to Upstream
vercel#79700