Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SV Liftover Code #240

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

SV Liftover Code #240

wants to merge 26 commits into from

Conversation

yashpatel6
Copy link
Collaborator

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the
    metadata.yaml and the manifest block in the nextflow.config as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline on at least one A-mini sample.

Adding code for output identification for SV pipelines and passing to StableLift pipeline for liftover.

The SV liftover options are currently disabled since StableLift expects a VCF and currently the SV pipelines output BCF. Once VCF output is added to the SV pipelines, the liftover can be enabled.

Much of the code in the output identification workflows is repetitive and should/will be separated into a single function in a future PR.

@yashpatel6 yashpatel6 requested a review from a team January 31, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants