Skip to content

fix(helm): allow electric db url var to be set from secret #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

fix(helm): allow electric db url var to be set from secret #2282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a63f5
correctly use db url from secret for electric
nicktrn Jul 18, 2025
a11ff36
bump app and chart version
nicktrn Jul 18, 2025
9675add
bump electric version
nicktrn Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hosting/docker/webapp/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ services:
start_period: 10s

electric:
image: electricsql/electric:${ELECTRIC_IMAGE_TAG:-1.0.13}
image: electricsql/electric:${ELECTRIC_IMAGE_TAG:-1.0.24}
restart: ${RESTART_POLICY:-unless-stopped}
logging: *logging-config
depends_on:
Expand Down
4 changes: 2 additions & 2 deletions hosting/k8s/helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: trigger
description: The official Trigger.dev Helm chart
type: application
version: 4.0.0-beta.17
appVersion: v4.0.0-v4-beta.22
version: 4.0.0-beta.18
appVersion: v4.0.0-v4-beta.23
home: https://trigger.dev
sources:
- https://github.com/triggerdotdev/trigger.dev
Expand Down
8 changes: 8 additions & 0 deletions hosting/k8s/helm/templates/electric.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,16 @@ spec:
containerPort: {{ .Values.electric.service.targetPort }}
protocol: TCP
env:
{{- if include "trigger-v4.postgres.useSecretUrl" . }}
- name: DATABASE_URL
valueFrom:
secretKeyRef:
name: {{ include "trigger-v4.postgres.external.secretName" . }}
key: {{ include "trigger-v4.postgres.external.databaseUrlKey" . }}
{{- else }}
- name: DATABASE_URL
value: {{ include "trigger-v4.postgres.connectionString" . | quote }}
{{- end }}
- name: ELECTRIC_INSECURE
value: {{ .Values.electric.config.insecure | quote }}
- name: ELECTRIC_USAGE_REPORTING
Expand Down
2 changes: 1 addition & 1 deletion hosting/k8s/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ electric:
image:
registry: docker.io
repository: electricsql/electric
tag: "1.0.13"
tag: "1.0.24"
pullPolicy: IfNotPresent
config:
insecure: true
Expand Down