Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn-install failure #393

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Fix yarn-install failure #393

merged 3 commits into from
Mar 18, 2025

Conversation

pudek357
Copy link
Contributor

@pudek357 pudek357 commented Mar 18, 2025

[TAPS-X]

This PR aims to properly fail workflow if yarn-install is failing.
Here is example when yarn-install from this branch properly failed: https://github.com/toptal/staff-portal/actions/runs/13917877637/job/38944177659#step:9:492
image

Here is a current master, where the status is set to success even though the yarn-install failed:
image

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping teams for review

@pudek357 pudek357 self-assigned this Mar 18, 2025
@pudek357 pudek357 requested a review from a team as a code owner March 18, 2025 07:27
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 3bfc7f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@george-aidonidis george-aidonidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pudek357 pudek357 force-pushed the fail-yarn-install-explicitly branch from de9f888 to cf477c4 Compare March 18, 2025 07:49
@pudek357 pudek357 merged commit 9985aa8 into master Mar 18, 2025
5 checks passed
@pudek357 pudek357 deleted the fail-yarn-install-explicitly branch March 18, 2025 08:45
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants