Fix yarn-install failure (#393)

Author: pudek357

.changeset/brave-timers-fly.md

@@ -0,0 +1,7 @@
+---
+'davinci-github-actions': patch
+---
+
+### yarn-install
+
+- ensure the workflow fails correctly if `yarn install` encounters an error

.github/workflows/pr-checks.yml

@@ -40,10 +40,10 @@ jobs:
         with:
           ref: ${{ github.event.pull_request.head.sha }}
 
-      - name: Set up Node.js 20
+      - name: Set up Node.js
         uses: actions/[email protected]
         with:
-          node-version: 20
+          node-version-file: .nvmrc
 
       - uses: ./yarn-install
 

.github/workflows/release.yml

@@ -56,7 +56,7 @@ jobs:
       - name: Set up node
         uses: actions/[email protected]
         with:
-          node-version: 20
+          node-version-file: .nvmrc
 
       - uses: ./yarn-install
 

.nvmrc

@@ -0,0 +1 @@
+20.18.3

build-push-image/README.md

@@ -42,7 +42,6 @@ This is a list of ENV Variables that are used in GH Action:
 | name                       | description                                               |
 | -------------------------- | --------------------------------------------------------- |
 | `DOCKER_BUILDX_ENDPOINT`   | Docker buildx endpoint (Optional if using for GH runners) |
-| `GCR_ACCOUNT_KEY`          | Necessary token to push image to Google cloud             |
 | `GITHUB_TOKEN`             | GitHub token. Is used to checkout `davinci` branch        |
 | `TOPTAL_BUILD_BOT_SSH_KEY` | SSH key to access Google cloud                            |
 

yarn-install/action.yml

@@ -161,11 +161,16 @@ runs:
         NPM_TOKEN: ${{ inputs.npm-token || env.NPM_TOKEN }}
         MAX_ATTEMPTS: ${{ inputs.max-attempts }}
       run: |
-        for i in {1..$MAX_ATTEMPTS}; do
-          printf "Trying to install #%s...\n" "$i"
-          yarn install --non-interactive && break
-          sleep 10 # 10s wait time
+        for ((i=1; i<=MAX_ATTEMPTS; i++)); do
+          echo "Trying to install (${i}/${MAX_ATTEMPTS})..."
+          if yarn install --non-interactive; then
+            echo "Yarn install succeeded on attempt ${i}."
+            exit 0
+          fi
+          sleep 10
         done
+        echo "All installation attempts failed. Exiting with error."
+        exit 1
 
       # We are manually checking for the changes in yarn.lock file, because
       # the `--frozen-lockfile` flag is not working correctly in workspaces with yarn v1