Feat/extend model list method #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method to add a model name for a given provider if the pre-defined list is not enough
|
Thank you for your contribution @shadokan87, I think this is a solution to a significant UX issue with the package. I've created a separate issue to discuss the topic: The only thing preventing me from merging this is that I want to be intentional about how this is implemented and make sure that we provide a solution that will work well and deliver a good developer experience. |
shadokan87
force-pushed
the
feat/extendModelList_method
branch
from
9cd29aa to
69bbbe2
Compare
handling the case where a custom model name is the same as a pre-defined one, slight doc changes
shadokan87
force-pushed
the
feat/extendModelList_method
branch
from
69bbbe2 to
1fed938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method to add a model name for a given provider if the pre-defined list is not enough