Skip to content

Update groq and perplexity models #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

rjmacarthy
Copy link
Contributor

@rjmacarthy rjmacarthy commented Jan 10, 2025

Hey, thanks for the awesome library I am planning to integrate it with my extension https://github.com/twinnydotdev/twinny will you be keeping the models updated? Is there a way we might be able to provide our own models, I see there is a PR for model extensions what are your plans? Many thanks.

@shadokan87
Copy link

@rjmacarthy I made a PR to have a method to use an unlisted models, It is not merged yet so I am using my forked version on NPM https://www.npmjs.com/package/@shadokan87/token.js, the PR: #127

@rjmacarthy
Copy link
Contributor Author

Hey @shadokan87 thanks for that I did already see that you have PR which looks useful. In all fairness I would prefer to keep to the original lib which is why I am asking about the future plans of the project. Many thanks!

@RPate97
Copy link
Contributor

RPate97 commented Jan 12, 2025

@shadokan87 This looks good, thank you for the PR. Please do the following so I can merge it:

  1. Run pnpm docs:update which will update the documentation
  2. Run pnpm lint:fix to resolve any linter errors.

@RPate97
Copy link
Contributor

RPate97 commented Jan 12, 2025

@shadokan87 @rjmacarthy Sorry I have not been prompt about reviewing #127. I wanted to spend some time considering if the UX of that PR is ideal.

I definitely agree that the need to update the library for every new model release is problematic, and I would like to address it. If you have time @rjmacarthy, I'd appreciate your thoughts on how best to address this. I've created, an issue for discussion on the topic: #129. Please let me know what you think, and if #127 would be an acceptable solution to you.

@shadokan87
Copy link

@RPate97 Alright cool, no problem I will do what you said also change a bit the readme then push again

@shadokan87 This looks good, thank you for the PR. Please do the following so I can merge it:

  1. Run pnpm docs:update which will update the documentation
  2. Run pnpm lint:fix to resolve any linter errors.

@rjmacarthy
Copy link
Contributor Author

I'm good with @shadokan87 solution however I am also happy to continue to help update the models as and when with new PRs. In this PR I also exported the models list which will help external parties when integrating the library to know what models are available. Many thanks.

@RPate97 RPate97 merged commit 0424eec into token-js:main Jan 14, 2025
3 checks passed
@RPate97
Copy link
Contributor

RPate97 commented Jan 14, 2025

@rjmacarthy That sounds great! Always happy to have contributions.

@rjmacarthy rjmacarthy deleted the chore/update-models branch March 8, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants