-
Notifications
You must be signed in to change notification settings - Fork 27
Update groq and perplexity models #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rjmacarthy I made a PR to have a method to use an unlisted models, It is not merged yet so I am using my forked version on NPM https://www.npmjs.com/package/@shadokan87/token.js, the PR: #127 |
Hey @shadokan87 thanks for that I did already see that you have PR which looks useful. In all fairness I would prefer to keep to the original lib which is why I am asking about the future plans of the project. Many thanks! |
@shadokan87 This looks good, thank you for the PR. Please do the following so I can merge it:
|
@shadokan87 @rjmacarthy Sorry I have not been prompt about reviewing #127. I wanted to spend some time considering if the UX of that PR is ideal. I definitely agree that the need to update the library for every new model release is problematic, and I would like to address it. If you have time @rjmacarthy, I'd appreciate your thoughts on how best to address this. I've created, an issue for discussion on the topic: #129. Please let me know what you think, and if #127 would be an acceptable solution to you. |
@RPate97 Alright cool, no problem I will do what you said also change a bit the readme then push again
|
I'm good with @shadokan87 solution however I am also happy to continue to help update the models as and when with new PRs. In this PR I also exported the models list which will help external parties when integrating the library to know what models are available. Many thanks. |
@rjmacarthy That sounds great! Always happy to have contributions. |
Hey, thanks for the awesome library I am planning to integrate it with my extension https://github.com/twinnydotdev/twinny will you be keeping the models updated? Is there a way we might be able to provide our own models, I see there is a PR for model extensions what are your plans? Many thanks.