-
Notifications
You must be signed in to change notification settings - Fork 0
jig formatted status #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
jig formatted status #249
Conversation
* feat(jig): show a unique name tip when deployment create fails * feat(jig): factor out config_path option and add short flag
78d2eef to
e085836
Compare
cd760c2 to
4676038
Compare
737d67d to
0d8af90
Compare
a55b852 to
c47076b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| else: | ||
| name = path.resolve().parent.name | ||
| click.echo(f"\N{PACKAGE} Name not set in config file or pyproject.toml - defaulting to {name}") | ||
| tip = "rename your folder or add `name` to {path}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing f-string prefix on tip string literals
Medium Severity
The tip assignments in the non-pyproject else branch are plain strings, not f-strings. "update \name` in {path}"and"rename your folder or add `name` to {path}"will include the literal text{path}instead of the actual file path. Compare with the pyproject branch which correctly hardcodes the path. This surfaces in the user-facing error message"Deployment name must be unique. Tip: ..."`.
| # "failed to delete secret" ("Failed to delete secret metadata from database" in logs) | ||
| # "failed to delete deployment from kubernetes: %w" | ||
| # errors for toKubernetesEnvironmentVariables, toKubernetesVolumeMounts, getCustomScalers, ReconcileWithKubernetes | ||
| error_message = getattr(e, "body", {}).get("error", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crash when API error body is None
Low Severity
getattr(e, "body", {}).get("error", "") will raise AttributeError if e.body is None. Since body is typed object | None on APIError, getattr returns None (the attribute exists), and calling .get() on None fails. This masks the original APIStatusError with a less informative generic error from the outer handle_api_errors handler.
bf5b62f to
f270535
Compare


Eg:
Note
Medium Risk
Touches
together beta jigdeploy/status flows and error handling; changes are user-facing and could affect CLI output expectations and deployment creation behavior, but are limited in scope and don’t change auth or core SDK transport.Overview
together beta jig statusnow defaults to a formatted, human-readable deployment report (with--jsonto keep raw output), implemented via a newformat_deployment_status()helper.Refactors
jigcommands to use a shared@jig_commanddecorator (adds-c/--configconsistently and centralizes API error handling), and improves deploy-time errors by computing a config-specific “unique name” tip and surfacing it when the API reports name-collision issues.Minor updates: README installation docs now use stable
pip install togetherand adduv add together, fine-tuning price estimation now forwardsfrom_checkpoint, and the generated OpenAPI spec pointer in.stats.ymlis updated.Written by Cursor Bugbot for commit 7aee2bd. This will update automatically on new commits. Configure here.