Conversation
* move volume mounts to config; remove set/unset * fix import * sort imports * ruff check --fix * no need to unset before delete
…aintain the same order (#234)
* [jig endpoint] fix base url for deployment-request * lint fix
7ceb8db to
3815764
Compare
| by_image[img].append((replica_name, replica_info)) | ||
|
|
||
| for img, replicas in sorted(by_image.items()): | ||
| lines.append(f"{img}:") |
There was a problem hiding this comment.
from the example in the description it is not immediately obvious that this is image tag:
Maybe preprent with something like Image -
There was a problem hiding this comment.
Fixed. Check description
| status_str = replica_info.get("replica_status", "Unknown") | ||
| reason = replica_info.get("replica_status_reason") | ||
| if reason and reason != status_str: | ||
| status_str = f"{status_str}:{reason}" |
There was a problem hiding this comment.
Would be great if we show volume preload status as well. One way to do that is, if there is 'volume_preload_status' and 'volume_preload_completed_at' is empty, show something like Loading volume contents
There was a problem hiding this comment.
Fixed. Check description
|
|
||
| age = _format_age(replica_info.get("replica_ready_since")) | ||
|
|
||
| lines.append(f" {replica_name}: {status_str}, Age {age}") |
There was a problem hiding this comment.
we can show revision_id as well. each replica event will have it(if replica is started). The latest revision id for the whole deployment you can take from environment variables. It is called TOGETHER_DEPLOYMENT_REVISION_ID
There was a problem hiding this comment.
Fixed. Check description
|
one minor thing, the deployment name can be removed from the secret name, because you do Also if it is a secret it shoudn't be included in the env part like this: |
3511302 to
450a589
Compare
7dc9e97 to
eafcf8e
Compare
technillogue
left a comment
There was a problem hiding this comment.
this should also probably be appropriately capitalized and styled to match, I wrote it out on slack intending it to be the rough content. for comparison:
App
Name = pybatch-api
Owner = personal
Hostname = pybatch-api.fly.dev
Image = pybatch-api:deployment-01KGJ96CPWZP54PPVH9R6SZD7W
Machines
PROCESS ID VERSION REGION STATE ROLE CHECKS LAST UPDATED
app 1850e41f309d38 21 sjc started 2026-02-03T17:36:31Z
during deploy:
Machines
PROCESS ID VERSION REGION STATE ROLE CHECKS LAST UPDATED
app 1850e41f309d38 22 sjc replacing 2026-02-05T04:10:36Z
or `wrangler deployments status`
| @@ -0,0 +1,171 @@ | |||
| """Utility functions for jig CLI commands.""" | |||
There was a problem hiding this comment.
I want to go back to having a single file anyway, this can go in jig.py, but it should be about half the line count
| # Extract just the tag from image if it's a full path | ||
| if ":" in img: | ||
| img = img.split(":")[-1] | ||
| # Handle digest format (image@sha256:...) |
There was a problem hiding this comment.
don't think this is correct when someone pushes an image without a tag
| lines: list[str] = [] | ||
|
|
||
| # Header section | ||
| name = data.get("name", "-") |
There was a problem hiding this comment.
I guess we could just use the pydantic response object for this
eafcf8e to
9c76da0
Compare
|
Closing this PR and continuing on #249 |
E.g: