-
-
Notifications
You must be signed in to change notification settings - Fork 2
[BACK-3970] Add spec for configurable TIDE report categories. #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bff2ba2
[BACK-3970] Add spec for selectable TIDE report categories.
lostlevels f018976
Reorder fields for easier reading.
lostlevels 3308098
Add timeInExtremeHigh.
lostlevels ef266d2
Remove noData from categories as it is a separate query parameter.
lostlevels bd45bb6
Add to description default TIDE categories.
lostlevels c7266a8
Update descriptions from code review.
lostlevels e9c5e97
Update naming of query param.
lostlevels 1efece7
Remove unused category. Rename timeInHighPercent => timeInAnyHighPerc…
lostlevels 373df47
Re-add timeInTargetPercent as an option.
lostlevels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,8 @@ GO_TOOLS = \ | |
$(TOOLS_BIN)/oapi-codegen | ||
|
||
$(TOOLS_BIN)/oapi-codegen: $(TOOLS_BIN) | ||
GOBIN=$(shell pwd)/$(TOOLS_BIN) go install github.com/deepmap/oapi-codegen/cmd/[email protected] | ||
GOBIN=$(shell pwd)/$(TOOLS_BIN) go install github.com/oapi-codegen/oapi-codegen/v2/cmd/[email protected] | ||
|
||
|
||
$(NPM_BIN)/%: | ||
$(MAKE) install_npm_pkgs | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,19 +16,23 @@ properties: | |
type: string | ||
format: date-time | ||
highGlucoseThreshold: | ||
description: Threshold used for determining if a value is high | ||
description: Minimum exclusive threshold in mmol/L for categorizing if a glucose value is high as established by the AACE. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm just pointing out that this goes against the intent of the custom ranges that have been designed and are themselves in code review. They don't necessarily need to align, but it seems like it'd be less confusing if they did. |
||
type: number | ||
x-go-type: float64 | ||
veryHighGlucoseThreshold: | ||
description: Threshold used for determining if a value is very high | ||
description: Minimum exclusive threshold in mmol/L for categorizing if a glucose value is very high as established by the AACE. | ||
type: number | ||
x-go-type: float64 | ||
extremeHighGlucoseThreshold: | ||
description: Minimum inclusive threshold in mmol/L for categorizing if a glucose value is extremely high. Not defined by the AACE. | ||
type: number | ||
x-go-type: float64 | ||
lowGlucoseThreshold: | ||
description: Threshold used for determining if a value is low | ||
description: Maximum exclusive threshold in mmol/L for categorizing if a glucose value is low as established by the AACE. | ||
type: number | ||
x-go-type: float64 | ||
veryLowGlucoseThreshold: | ||
description: Threshold used for determining if a value is very low | ||
description: Maximum exclusive threshold in mmol/L for categorizing if a glucose value is very low as established by the AACE. | ||
type: number | ||
x-go-type: float64 | ||
tags: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,37 @@ | ||
type: object | ||
title: tidefilters.v1 | ||
description: '' | ||
description: 'Visual representation of filtered categories selected' | ||
properties: | ||
timeInVeryLowPercent: | ||
dropInTimeInTargetPercent: | ||
ewollesen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
timeCGMUsePercent: | ||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
timeInAnyLowPercent: | ||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
dropInTimeInTargetPercent: | ||
timeInExtremeHighPercent: | ||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
timeInHighPercent: | ||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
timeInTargetPercent: | ||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
timeCGMUsePercent: | ||
timeInVeryHighPercent: | ||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
timeInVeryLowPercent: | ||
type: string | ||
pattern: ^(>=|>|<=|<)\d\.\d\d?$ | ||
example: '>0.5' | ||
|
||
required: | ||
ewollesen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- timeInVeryLowPercent | ||
- timeInAnyLowPercent | ||
- dropInTimeInTargetPercent | ||
- timeInTargetPercent | ||
- timeCGMUsePercent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.