[BACK-3970] Add spec for configurable TIDE report categories. #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ewollesen
reviewed
Sep 12, 2025
lostlevels
force-pushed
the
jp-back-3970-tide-categories
branch
from
9e016c5 to
bff2ba2
Compare
ewollesen
previously approved these changes
Sep 29, 2025
ewollesen
reviewed
Oct 6, 2025
ewollesen
previously approved these changes
Oct 9, 2025
| format: date-time | ||
| highGlucoseThreshold: | ||
| description: Threshold used for determining if a value is high | ||
| description: Minimum exclusive threshold in mmol/L for categorizing if a glucose value is high as established by the AACE. |
There was a problem hiding this comment.
I'm just pointing out that this goes against the intent of the custom ranges that have been designed and are themselves in code review.
They don't necessarily need to align, but it seems like it'd be less confusing if they did.
ewollesen
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.