Skip to content

docs: Fix example input event code errors #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

docs: Fix example input event code errors #1223

merged 2 commits into from
Feb 20, 2023

Conversation

morgan121
Copy link
Contributor

@morgan121 morgan121 commented Feb 20, 2023

  1. 3 instances of const were missing from function declarations - these have been added
  2. The getByLabelText on line 35 was underlined in red saying
    to use screen instead of utils

Resolves #1222

the getByLabelText on line 35 was underlined in red saying
to use screen instead
@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 73a13bc
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/63f31eba902d3100082e117d
😎 Deploy Preview https://deploy-preview-1223--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@morgan121 morgan121 mentioned this pull request Feb 20, 2023
Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect :)
Thank you!

@MatanBobi MatanBobi merged commit 4eee597 into testing-library:main Feb 20, 2023
@MatanBobi
Copy link
Member

@all-contributors please add @morgan121 for docs :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @morgan121! 🎉

@morgan121 morgan121 deleted the morgan121/add-missing-const-declarations branch February 20, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing const
2 participants