Skip to content

Missing const #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
morgan121 opened this issue Feb 20, 2023 · 5 comments · Fixed by #1223
Closed

Missing const #1222

morgan121 opened this issue Feb 20, 2023 · 5 comments · Fixed by #1223
Labels
good first issue 🏁 Good for newcomers

Comments

@morgan121
Copy link
Contributor

Looks like line 19, 20 and 22 of this file are missing the word const? meant the example errored when I tried to test it locally

testing-library-docs/docs/example-input-event.mdx

Line 19 in 8acaf6e

removeDollarSign = value => (value[0] === '$' ? value.slice(1) : value)

@MatanBobi
Copy link
Member

Looks like you're right :) want to create a PR?

@morgan121
Copy link
Contributor Author

happy to. to do that do I just clone the repo and then push a branch? never contributed to someone elses repo before

@MatanBobi
Copy link
Member

You'll first need to fork the repo and then clone your fork 🙂 I recommend taking a quick look at this course

@morgan121
Copy link
Contributor Author

ok, seems like a bit more work. will try and look later if i get time

@MatanBobi MatanBobi added the good first issue 🏁 Good for newcomers label Feb 20, 2023
@morgan121
Copy link
Contributor Author

ok - PR is here, think I did it right? #1223

@MatanBobi MatanBobi mentioned this issue Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🏁 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Fix example input event code errors
2 participants
@MatanBobi @morgan121