Skip to content

Improve combobox input sizing and spacing #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −2
Draft

Improve combobox input sizing and spacing #2896

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa27f2
feat(combobox): improve input sizing and add right padding
rossnelson Sep 8, 2025
95a8b14
feat(combobox): add configurable autoWidth prop for dynamic input sizing
rossnelson Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions src/lib/holocene/combobox/combobox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
variant?: ComboboxStyles['variant'];
class?: string;
optionClass?: string;
autoWidth?: boolean;
}

type MultiSelectProps = {
Expand Down Expand Up @@ -165,6 +166,7 @@
export let loadingText = 'Loading more results';
export let variant: ComboboxStyles['variant'] = 'default';
export let optionClass = '';
export let autoWidth = false;

export let numberOfItemsSelectedLabel = (count: number) =>
`${count} option${count > 1 ? 's' : ''} selected`;
Expand All @@ -177,6 +179,8 @@
let selectedOption: string | T;
let menuElement: HTMLUListElement;
let inputElement: HTMLInputElement;
let measureElement: HTMLSpanElement;
let inputWidth = 'auto';

export let open = writable<boolean>(false);
export let maxMenuHeight: string = 'max-h-[20rem]';
Expand All @@ -194,8 +198,23 @@
// We want this to react to external changes to the options prop to support async use cases
$: list = filterOptions(filterValue, options);

// Dynamically adjust input width based on content when autoWidth is enabled
$: {
if (inputElement && displayValue) {
if (autoWidth && measureElement && inputElement) {
const textToMeasure = displayValue || placeholder || '';
measureElement.textContent = textToMeasure;
const measuredWidth = measureElement.offsetWidth;
// Add some padding for cursor and better UX
const paddingBuffer = 20;
const minWidth = 100;
const maxWidth = 400;
const targetWidth = Math.min(
Math.max(measuredWidth + paddingBuffer, minWidth),
maxWidth,
);
inputWidth = `${targetWidth}px`;
} else if (!autoWidth && inputElement && displayValue) {
// Use the original size-based behavior for backward compatibility
if (displayValue.length < minSize) {
inputElement.size = minSize;
} else if (displayValue.length > maxSize) {
Expand Down Expand Up @@ -470,6 +489,7 @@
{disabled}
type="text"
value={displayValue}
style={autoWidth ? `width: ${inputWidth}` : undefined}
class={merge(
'combobox-input',
multiselect
Expand Down Expand Up @@ -497,6 +517,15 @@
bind:this={inputElement}
{...$$restProps}
/>
{#if autoWidth}
<!-- Hidden span for measuring text width -->
<span
bind:this={measureElement}
class="combobox-input"
style="position: absolute; visibility: hidden; white-space: pre;"
aria-hidden="true"
/>
{/if}
</div>
{#if $$slots.action}
<div class="ml-1 flex h-full items-start border-l border-subtle p-0.5">
Expand Down Expand Up @@ -609,6 +638,6 @@
}

.combobox-input {
@apply flex grow bg-transparent text-primary placeholder:text-secondary focus:outline-none;
@apply flex grow bg-transparent pr-2 text-primary placeholder:text-secondary focus:outline-none;
}
</style>
Loading