Improve combobox input sizing and spacing #2896
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set min-width: 0 and width: auto for flexible sizing - Use flex: 1 1 auto to allow natural growth/shrink - Add right padding (pr-2) for better visual spacing
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add autoWidth prop (defaults to false for backward compatibility) - When enabled, dynamically adjusts input width based on content - Uses hidden span element to measure text width - Maintains original size-based behavior when autoWidth is false - Add right padding for improved visual spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
Instead of using the newer
field-sizing: contentCSS property (which isn't supported by stylelint), this uses a combination of:min-width: 0to allow the input to shrink below its content widthwidth: autofor natural sizingflex: 1 1 autoto allow flexible growth and shrinking within the flex containerpr-2(padding-right) for better visual spacingThis approach provides similar benefits to
field-sizing: contentwhile maintaining compatibility with our current tooling.Test Plan
[ ] Test combobox behavior with various content lengths
[ ] Verify input expands/contracts appropriately
[ ] Check multiselect mode still works correctly
[ ] Confirm visual spacing looks good in different states