Adds support for Bytes to ColumnSumCheck #45
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpisciuneri
approved these changes
May 22, 2020
Collaborator
|
@colindean Since I had to modify the same files to address @phpisciuneri 's review comments, I have included your changes for this PR in #43 . |
Collaborator
Author
|
We'll close this after #43 is merged, then. When you pulled in this PR's branch, did you copy-paste or use |
samratmitra-0812
pushed a commit
that referenced
this pull request
May 27, 2020
samratmitra-0812
pushed a commit
that referenced
this pull request
May 27, 2020
…idator into BugFix-IncorrectErrorPct Remove code copied from #45
Contributor
|
@samratmitra-0812 can you formally approve if you are satisfied? See About Pull Request Reviews |
samratmitra-0812
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.