Skip to content

Commit 954c18f

Browse files
SamratMitraSamratMitra
authored andcommitted
Removed #45 changes and correct spelling mistake
1 parent 51b30f8 commit 954c18f

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ This check sums a column in all rows. If the sum applied to the `column` doesn't
324324
| `maxValue` | NumericType | The upper bound of the sum. Type depends on the type of the `column`. |
325325
| `inclusive` | Boolean | Include `minValue` and `maxValue` as part of the range. |
326326

327-
**Note:** If bounds are non-inclusive, and the actual sum is eequal to one of the bounds, the relative error percentage will be undefined.
327+
**Note:** If bounds are non-inclusive, and the actual sum is equal to one of the bounds, the relative error percentage will be undefined.
328328

329329
## Example Config
330330

src/test/scala/com/target/data_validator/TestHelpers.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ object TestHelpers {
2525
case "java.lang.Double" => DoubleType
2626
case "java.lang.Boolean" => BooleanType
2727
case "java.lang.Long" => LongType
28-
case "java.lang.Byte" => ByteType
2928
case _ => throw new IllegalArgumentException(s"Unknown type '${v.getClass.getCanonicalName}'")
3029
}
3130

src/test/scala/com/target/data_validator/validator/ColumnSumCheckSpec.scala

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -207,22 +207,14 @@ class ColumnSumCheckSpec extends FunSpec with Matchers with TestingSparkSession
207207
assert(!sut.failed)
208208
}
209209

210-
it("upper bound success with short") {
210+
it("upper bound success") {
211211
val check = ColumnSumCheck("foo", maxValue = Some(Json.fromDouble(10).get)) // scalastyle:ignore magic.number
212212
val df = mkDf(spark, "foo" -> List[Short](1, 2, 1))
213213
val sut = ValidatorDataFrame(df, None, None, List(check))
214214
assert(!sut.quickChecks(spark, mkDict())(config))
215215
assert(!sut.failed)
216216
}
217217

218-
it("upper bound success with byte") {
219-
val check = ColumnSumCheck("foo", maxValue = Some(Json.fromDouble(10).get)) // scalastyle:ignore magic.number
220-
val df = mkDf(spark, "foo" -> List[Byte](1, 2, 1))
221-
val sut = ValidatorDataFrame(df, None, None, List(check))
222-
assert(!sut.quickChecks(spark, mkDict())(config))
223-
assert(!sut.failed)
224-
}
225-
226218
it("upper bound failure") {
227219
val check = ColumnSumCheck("foo", maxValue = Some(Json.fromFloat(1).get)) // scalastyle:ignore magic.number
228220
val df = mkDf(spark, "foo" -> List(1L, 1L, 1L))

0 commit comments

Comments
 (0)