Skip to content

test(upgrade): enable SCSS #{!important} @apply migration test #19738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pavan-sh wants to merge 2 commits into from
+2 −2
Closed

test(upgrade): enable SCSS #{!important} @apply migration test #19738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcd48d7
test(upgrade): enable SCSS #{!important} @apply migration test
pavan-sh Feb 23, 2026
ea599d9
Merge branch 'main' into feat/upgrade-handle-scss-at-apply
pavan-sh Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
userConfig: config,
}),
)
.process(input, { from: expect.getState().testPath })

Check failure on line 32 in packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts

View workflow job for this annotation

GitHub Actions / Linux

[@tailwindcss/upgrade] src/codemods/css/migrate-at-apply.test.ts > should append `!` to each utility, when using `#{!important}` 

CssSyntaxError: /home/runner/work/tailwindcss/tailwindcss/packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts:2:26: Unknown word !important
 ❯ Input.error ../../node_modules/.pnpm/postcss@8.5.6/node_modules/postcss/lib/input.js:135:16
 ❯ Parser.unknownWord ../../node_modules/.pnpm/postcss@8.5.6/node_modules/postcss/lib/parser.js:595:22
 ❯ Parser.other ../../node_modules/.pnpm/postcss@8.5.6/node_modules/postcss/lib/parser.js:437:12
 ❯ Parser.parse ../../node_modules/.pnpm/postcss@8.5.6/node_modules/postcss/lib/parser.js:472:16
 ❯ parse ../../node_modules/.pnpm/postcss@8.5.6/node_modules/postcss/lib/parse.js:11:12
 ❯ new LazyResult ../../node_modules/.pnpm/postcss@8.5.6/node_modules/postcss/lib/lazy-result.js:165:16
 ❯ Processor.process ../../node_modules/.pnpm/postcss@8.5.6/node_modules/postcss/lib/processor.js:53:14
 ❯ migrate src/codemods/css/migrate-at-apply.test.ts:32:6
 ❯ src/codemods/css/migrate-at-apply.test.ts:67:5

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { reason: 'Unknown word !important', file: '/home/runner/work/tailwindcss/tailwindcss/packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts', source: '.foo {\n  @apply flex flex-col #{!important};\n}', endLine: 2, endColumn: 36, input: { column: 26, endColumn: 36, endLine: 2, endOffset: 42, line: 2, offset: 32, source: '.foo {\n  @apply flex flex-col #{!important};\n}', url: 'file:///home/runner/work/tailwindcss/tailwindcss/packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts', file: '/home/runner/work/tailwindcss/tailwindcss/packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts' }, setMessage: 'Function<setMessage>', showSourceCode: 'Function<showSourceCode>' }
.then((result) => result.css)
}

Expand Down Expand Up @@ -61,8 +61,8 @@
`)
})

// TODO: Handle SCSS syntax
it.skip('should append `!` to each utility, when using `#{!important}`', async () => {
// SCSS: Sass interpolation for !important is supported
it('should append `!` to each utility, when using `#{!important}`', async () => {
expect(
await migrate(css`
.foo {
Expand Down
Loading