test(upgrade): enable SCSS #{!important} @apply migration test#19738
test(upgrade): enable SCSS #{!important} @apply migration test#19738pavan-sh wants to merge 2 commits intotailwindlabs:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughA skipped test in the migrate-at-apply test suite was enabled. The test validates Sass interpolation for the !important declaration using the 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi team, I'll enable the SCSS #(!important} @apply migration test. Let me work on this! |
|
Hey! We skipped this test on purpose, we're currently not looking to add SCSS support. Thanks! |
No problem. Thanks for review and valuable time. |
Summary
This PR enables coverage for Sass/SCSS
@applyusage with interpolation (#{!important}) in the@tailwindcss/upgradecodemod.The codemod already handles
#{!important}inmigrate-at-apply.ts, but the corresponding test was previously skipped with a TODO. This change removes the skip and updates the comment so CI will catch regressions and the supported behavior stays documented.Test plan
packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.tsby un-skipping the#{!important}case and verifying the expected output snapshot.Recommended CI/local verification in a full dev environment (with Rust toolchain available):
pnpm install pnpm test