Skip to content

Initialized the nkamuo/barcode-bundle project #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions nkamuo/barcode-bundle/1.0-dev/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Barcode Bundle Recipe

This recipe installs the configuration for the Barcode Bundle.

## Installed Files

The following files are installed:

- `config/packages/barcode.yaml`: Configuration for your bundle.
- `config/bundles.php`: Auto-registers the `Nkamuo\Barcode\BarcodeBundle`.

You can customize the configuration in `barcode.yaml`.

Check failure on line 12 in nkamuo/barcode-bundle/1.0-dev/README.md

View workflow job for this annotation

GitHub Actions / call-qa / Run checks

Should end with a newline
5 changes: 5 additions & 0 deletions nkamuo/barcode-bundle/1.0-dev/config/bundle.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be removed, bundle entry will be created by manifest via

            "Nkamuo\\Barcode\\BarcodeBundle": ["all"]

line.

Here is documentation https://github.com/symfony/recipes?tab=readme-ov-file#bundles-configurator

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?php

return [
Nkamuo\Barcode\BarcodeBundle::class => ['all' => true],
];

Check failure on line 5 in nkamuo/barcode-bundle/1.0-dev/config/bundle.php

View workflow job for this annotation

GitHub Actions / call-qa / Run checks

Should end with a newline
3 changes: 3 additions & 0 deletions nkamuo/barcode-bundle/1.0-dev/config/packages/barcode.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
barcode:
default_storage: 'in_memory'
enabled_formatters: ['qrcode', 'barcode']

Check failure on line 3 in nkamuo/barcode-bundle/1.0-dev/config/packages/barcode.yaml

View workflow job for this annotation

GitHub Actions / call-qa / Run checks

Should end with a newline
10 changes: 10 additions & 0 deletions nkamuo/barcode-bundle/1.0-dev/manufest.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename manifest file to correct spelling.

--- nkamuo/barcode-bundle/1.0-dev/manufest.json
+++ nkamuo/barcode-bundle/1.0-dev/manifest.json

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"manifest": {
"bundles": {
"Nkamuo\\Barcode\\BarcodeBundle": ["all"]
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
}
}
}

Check failure on line 10 in nkamuo/barcode-bundle/1.0-dev/manufest.json

View workflow job for this annotation

GitHub Actions / call-qa / Run checks

Should end with a newline
Loading