Skip to content

Initialized the nkamuo/barcode-bundle project #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nkamuo
Copy link

@nkamuo nkamuo commented Apr 13, 2025

No description provided.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) April 13, 2025 14:44
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1777/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1777/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'nkamuo/barcode-bundle:^1.0-dev'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix suggested CI coding style issues.

image

Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please license this PR in order for CI to pass and PR to be accepted.
Here is example, which should be added to PR description

| Q             | A
| ------------- | ---
| License       | MIT
| Packagist     | https://packagist.org/packages/nkamuo/barcode-bundle

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be removed, bundle entry will be created by manifest via

            "Nkamuo\\Barcode\\BarcodeBundle": ["all"]

line.

Here is documentation https://github.com/symfony/recipes?tab=readme-ov-file#bundles-configurator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename manifest file to correct spelling.

--- nkamuo/barcode-bundle/1.0-dev/manufest.json
+++ nkamuo/barcode-bundle/1.0-dev/manifest.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants