[Concurrency] Correct memory effect attributes of task_create #82179
+31
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Without this, llvm would sometimes wrongly assume there's no indirect accesses and the optimizations can lead to a runtime crash, by optimizing away initializing options properly. Resolves rdar://152548190
ktoso
force-pushed
the
wip-fix-incorrect-memory-effects-on-task-create
branch
from
73b6746 to
3aa28b4
Compare
|
@swift-ci please smoke test |
ktoso
commented
Jun 11, 2025
| @@ -79,8 +79,6 @@ extension Task where Failure == ${FAILURE_TYPE} { | |||
| public static func immediate( | |||
| name: String? = nil, | |||
| priority: TaskPriority? = nil, | |||
| % # NOTE: This closure cannot be 'sending' because we'll trigger ' pattern that the region based isolation checker does not understand how to check' | |||
| % # In this case: `func syncOnMyGlobalActor() { Task.immediate { @MyGlobalActor in } }` | |||
There was a problem hiding this comment.
we actually did adopt sending here already, so we can remove the comment about needing to do so when a bug was fixed
ktoso
commented
Jun 11, 2025
| // 69: - async work on queue | ||
| // 71: Inner thread id = 0x00007000054f5000 | ||
| // 72: Current thread id = 0x000070000567e000 | ||
| // 73: inside immediate, done [thread:0x000070000567e000] @ :414 |
There was a problem hiding this comment.
no need to keep this in tree, was debug information
ktoso
commented
Jun 11, 2025
| Task.immediate(name: "hello") { @MainActor in print("Task.immediate { @MainActor } (\(Task.name!))") } | ||
| Task.immediate() { @MainActor in print("Task.immediate { @MainActor }") } | ||
| } | ||
| } |
There was a problem hiding this comment.
testing both with names and not, to be "extra" sure these don't regress somehow
fhahn
reviewed
Jun 11, 2025
rjmccall
approved these changes
Jun 11, 2025
|
@swift-ci please smoke test |
|
Thanks for review folks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, llvm would sometimes wrongly assume there's no indirect
accesses and the optimizations can lead to a runtime crash, by
optimizing away initializing options properly.
Resolves rdar://152548190