[6.2][Concurrency] Correct memory effect attributes of task_create #82180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, llvm would sometimes wrongly assume there's no indirect accesses and the optimizations can lead to a runtime crash, by optimizing away initializing options properly. Resolves rdar://152548190
|
@swift-ci please test |
hborla
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Without this, llvm would sometimes wrongly assume there's no indirect
accesses and the optimizations can lead to a runtime crash, by optimizing away initializing options properly.
Scope/Impact: Users of some apis which have multiple task options can experience crashes; This only manifested on some startSynchronously legacy API users so far but this is purely accidental -- it seems other APIs were just "lucky" (for years), since the functions were AEIC.
Risk: Low, corrects memory semantics annotation to prevent too aggressive optimizations.
Testing: Added test which triggered the miscompile.
Reviewed by: @mikeash @fhahn @rjmccall
Original PR: #82179
Radar: rdar://152548190