[CS] Avoid solver-allocated inputs with typesSatisfyConstraint
#82147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
approved these changes
Jun 10, 2025
xedin
approved these changes
Jun 10, 2025
|
Nice catch! |
This is now unused.
We should never end up here, we should have placeholder bindings instead for holes.
I don't believe we ever form these types, and if we did we aren't correctly handling them in `Solution::simplifyType`. Let's just enforce we don't get them.
Escaping solver-allocated types into a nested allocation arena is problematic since we can e.g lazily compute the `ContextSubMap` for a `NominalOrBoundGenericNominalType`, which is then destroyed when we exit the nested arena. Ensure we don't pass any types with type variables or placeholders to `typesSatisfyConstraint`. rdar://152763265
hamishknight
force-pushed
the
fix-nested-arenas
branch
from
7a0d3e1 to
5861c1f
Compare
hamishknight
commented
Jun 12, 2025
…entMemberType` `substBase` here can contain type variables or placeholders, avoid using them as the original ErrorTypes since ErrorTypes cannot be solver-allocated currently. This only affects type printing so shouldn't matter much.
hamishknight
force-pushed
the
fix-nested-arenas
branch
from
5861c1f to
db49faf
Compare
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escaping solver-allocated types into a nested allocation arena is problematic since we can e.g lazily compute the
ContextSubMapfor aNominalOrBoundGenericNominalType, which is then destroyed when we exit the nested arena. Ensure we don't pass any types with type variables or placeholders totypesSatisfyConstraint.rdar://152763265