[6.2] [CS] Avoid solver-allocated inputs with typesSatisfyConstraint
#82152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escaping solver-allocated types into a nested allocation arena is problematic since we can e.g lazily compute the `ContextSubMap` for a `NominalOrBoundGenericNominalType`, which is then destroyed when we exit the nested arena. Ensure we don't pass any types with type variables or placeholders to `typesSatisfyConstraint`. rdar://152763265
Check for `isSolverAllocated` rather than `hasTypeVariableOrPlaceholder`, and downgrade an `ASSERT` to `CONDITIONAL_ASSERT`.
|
@swift-ci please test |
xedin
approved these changes
Jun 10, 2025
|
@swift-ci please test source compatibility |
hborla
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #82147, minus the more risky parts of that change
ContextSubMapfor aNominalOrBoundGenericNominalTypeis lazily computed. This resulted in use-after-frees.isSolverAllocatedinstead ofhasTypeVariableOrPlaceholder.