Skip to content

Implement MODULE [AP-4230] #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

martin4861
Copy link
Contributor

@martin4861 martin4861 commented Aug 15, 2025

@martin4861 martin4861 changed the title Implement MODULE [WIP] Implement MODULE [AP-4230][WIP] Aug 15, 2025
@martin4861 martin4861 force-pushed the martin4861/implement-MODULE branch from 17b58b9 to aaad9a1 Compare August 15, 2025 08:07
@martin4861 martin4861 force-pushed the martin4861/implement-MODULE branch from aaad9a1 to 33e889e Compare August 15, 2025 08:08
@martin4861 martin4861 force-pushed the martin4861/implement-MODULE branch from 6a85754 to e0b446c Compare August 15, 2025 08:37
@martin4861 martin4861 changed the title Implement MODULE [AP-4230][WIP] Implement MODULE [AP-4230] Aug 18, 2025
@martin4861 martin4861 marked this pull request as ready for review August 18, 2025 11:37
@martin4861 martin4861 requested review from armallen and peddie August 18, 2025 14:13
@@ -105,10 +105,13 @@ jobs:
submodules: recursive
ssh-key: ${{ secrets.SSH_KEY }}

- uses: bazel-contrib/[email protected]
- uses: bazelbuild/setup-bazelisk@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup-bazel now supersedes setup-bazelisk

is there a missing functionality in the new action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, I will revert that change!

@martin4861 martin4861 requested a review from armallen August 18, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants