[ETHEREUM-CONTRACTS] emit Transfer event on flow create/delete and units changing from/to 0 #2114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Is it from the original OZ old code base of ERC777/ERC20 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hellwolf
reviewed
Oct 22, 2025
packages/ethereum-contracts/contracts/agreements/ConstantFlowAgreementV1.sol
Outdated
Show resolved
Hide resolved
hellwolf
reviewed
Oct 22, 2025
packages/ethereum-contracts/contracts/agreements/gdav1/SuperfluidPool.sol
Outdated
Show resolved
Hide resolved
|
to address #2115 too |
d10r
changed the title
answered here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why
Many indexers (e.g. explorers) rely on the ERC20
Transfereventa) for managing the set of token holders,.
b) for triggering a balance calculation
With SuperTokens, that can lead to accounts receiving via flows or distributions to remain invisible, and for the balance to never be updated.
How
By emitting Transfer events, we shall be able to somewhat mitigate this issues:
a) by emitting a Transfer event when creating a flow or assigning pool units, the receiving account is included in the set of token holders to be considered
b) by emitting a Transfer event when deleting a flow or resetting pool units, some indexers may trigger a balance check and thereby update the account balance to the correct number
Other
Also bumped version to 1.14.0 as this may be the last PR before release.