Skip to content

[PROTOCOL] don't emit Approval in transferFrom #2115

@d10r

Description

@d10r

What & Why

Due to the way it's implemented, transferFrom does emit an Approval event when subtracting the amount being transferred from the allowance. That seems wrong.

Next: check ERC20 spec and reference implementations if this is indeed unexpected behaviour.
If so, check where this is coming from (ERC777 implementation?). Remove.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions