Skip to content

fix: use kebab-case to align with spec #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ferhatelmas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use kebab-case to align with spec #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ const metadata = await catalog.createTable(
'spec-id': 0,
fields: [
{
source_id: 2,
field_id: 1000,
'source-id': 2,
'field-id': 1000,
name: 'ts_day',
transform: 'day',
},
Expand Down
4 changes: 2 additions & 2 deletions examples/basic-usage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ async function main() {
'spec-id': 0,
fields: [
{
source_id: 2,
field_id: 1000,
'source-id': 2,
'field-id': 1000,
name: 'ts_day',
transform: 'day',
},
Expand Down
4 changes: 2 additions & 2 deletions examples/supabase-storage-usage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ async function main() {
'spec-id': 0,
fields: [
{
source_id: 3, // timestamp field
field_id: 1000,
'source-id': 3, // timestamp field
'field-id': 1000,
name: 'event_day',
transform: 'day',
},
Expand Down
2 changes: 1 addition & 1 deletion src/catalog/IcebergRestCatalog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export class IcebergRestCatalog {
* 'partition-spec': {
* 'spec-id': 0,
* fields: [
* { source_id: 2, field_id: 1000, name: 'ts_day', transform: 'day' }
* { 'source-id': 2, 'field-id': 1000, name: 'ts_day', transform: 'day' }
* ]
* }
* }
Expand Down
8 changes: 4 additions & 4 deletions src/catalog/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ export interface TableSchema {
}

export interface PartitionField {
source_id: number
field_id: number
'source-id': number
'field-id': number
name: string
transform: string
}
Expand All @@ -205,10 +205,10 @@ export interface PartitionSpec {
}

export interface SortField {
source_id: number
'source-id': number
transform: string
direction: 'asc' | 'desc'
null_order: 'nulls-first' | 'nulls-last'
'null-order': 'nulls-first' | 'nulls-last'
}

export interface SortOrder {
Expand Down
8 changes: 4 additions & 4 deletions test/catalog/tables.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ describe('TableOperations', () => {
'spec-id': 0,
fields: [
{
source_id: 2,
field_id: 1000,
'source-id': 2,
'field-id': 1000,
name: 'ts_day',
transform: 'day',
},
Expand All @@ -183,8 +183,8 @@ describe('TableOperations', () => {
'spec-id': 0,
fields: [
{
source_id: 2,
field_id: 1000,
'source-id': 2,
'field-id': 1000,
name: 'ts_day',
transform: 'day',
},
Expand Down