Pool unblocking + shutdown #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
==========================================
+ Coverage 19.31% 20.32% +1.01%
==========================================
Files 131 122 -9
Lines 9298 8732 -566
==========================================
- Hits 1796 1775 -21
+ Misses 7502 6957 -545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbesraa
force-pushed
the
2025-03-10/pool-shutdown
branch
5 times, most recently
from
adb54a6 to
ac0f902
Compare
Shourya742
suggested changes
Mar 12, 2025
jbesraa
force-pushed
the
2025-03-10/pool-shutdown
branch
2 times, most recently
from
6fc888e to
9ea1a68
Compare
plebhash
reviewed
Mar 14, 2025
plebhash
reviewed
Mar 14, 2025
This was referenced Mar 18, 2025
jbesraa
force-pushed
the
2025-03-10/pool-shutdown
branch
from
9ea1a68 to
fef0cf3
Compare
jbesraa
force-pushed
the
2025-03-10/pool-shutdown
branch
4 times, most recently
from
e49d6d7 to
d58772c
Compare
plebhash
approved these changes
Mar 19, 2025
Currently the state loop at the end of `PoolSv2::start` is blocking, it is wrapped with `tokio::task` so we can return from the `start` function. This should give us more flexibelty in how we work with `PoolSv2`. For example we can access the `PoolSv2` state directly through the struct.
A simple shutdown function that exits the State loop and shutsdown the Pool server.
jbesraa
force-pushed
the
2025-03-10/pool-shutdown
branch
from
d58772c to
40f2e66
Compare
jbesraa
force-pushed
the
2025-03-10/pool-shutdown
branch
from
40f2e66 to
af6f3c5
Compare
plebhash
reviewed
Mar 20, 2025
Comment on lines
-276
to
-279
| info!( | ||
| "Listening for encrypted connection on: {}", | ||
| config.listen_address() | ||
| ); |
There was a problem hiding this comment.
the fact that we're changing this log is prevenging MG sv1-test from asserting that pool_sv2 has properly launched, which is making the test get stuck
so I'm adding to this PR c8a721b to unblock CI and proceed with merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1320