You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this table should guide the CI migration away from MG
MG test
migration strategy
comment
issue
migration status
pool-sri-test-reject-auth
removal
motivation for test is not clear
MG_reject_auth doesn't make sense
> Probably this was a test related to some initial work related to authentication mechanisms which were never really implemented. > I think we should add a proper test in the future, as soon as we will have some kind of auth system in place on the Pool. #1482 (comment)
requires further investigation, we're not sure if "outdated" job_id is a sufficient criteria for rejecting shares
additionally, this test could potentially require a way to intercept/replace Sv1 messages (Sv1 Sniffer?), which could be a substantial engineering effort
so for now, I'd postpone (and potentially discard) this migration
Aside from the MG tests listed above, #1077 are also keeping track of some issues that are lacking CI and should eventually be covered by Integration Tests.
The text was updated successfully, but these errors were encountered:
this table should guide the CI migration away from MG
MG_reject_auth
doesn't make sense> Probably this was a test related to some initial work related to authentication mechanisms which were never really implemented.
> I think we should add a proper test in the future, as soon as we will have some kind of auth system in place on the Pool.
#1482 (comment)
additionally, this test could potentially require a way to intercept/replace Sv1 messages (Sv1 Sniffer?), which could be a substantial engineering effort
so for now, I'd postpone (and potentially discard) this migration
async
flag ofSetupConnection
is being replaced via stratum-mining/sv2-spec#121, so this test should change strategyasync
flag ofSetupConnection
is being replaced via stratum-mining/sv2-spec#121, so this test should change strategydo we even want tProxy to shutdown just because pool sent a bad extranonce_prefix?
#1582
do we even want tProxy to shutdown just because pool closed a channel?
#1582
mining-proxy
implementation is very problematic and not used anywhere, it's not worth trying to test it nowmining-proxy
implementation is very problematic and not used anywhere, it's not worth trying to test it nowAside from the MG tests listed above, #1077 are also keeping track of some issues that are lacking CI and should eventually be covered by Integration Tests.
The text was updated successfully, but these errors were encountered: