Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI migration: MG to Integration/Unit Tests #1121

Open
Tracked by #1120
plebhash opened this issue Aug 19, 2024 · 0 comments
Open
Tracked by #1120

CI migration: MG to Integration/Unit Tests #1121

plebhash opened this issue Aug 19, 2024 · 0 comments
Labels
ci/cd CI/CD integration-tests message-generator tracker Help us track a group of related issues
Milestone

Comments

@plebhash
Copy link
Collaborator

plebhash commented Aug 19, 2024

this table should guide the CI migration away from MG

MG test migration strategy comment issue migration status
pool-sri-test-reject-auth removal motivation for test is not clear

MG_reject_auth doesn't make sense

> Probably this was a test related to some initial work related to authentication mechanisms which were never really implemented.
> I think we should add a proper test in the future, as soon as we will have some kind of auth system in place on the Pool.
#1482 (comment)
#1481 #1482
translation-proxy integration test will greatly improve CI experience, MG test is highly undeterministic #1208 #1262
interop-jd-translator integration test #1353 #1354
bad-pool-config-test unit test this test is asserting internal architecture flow, not message flow between roles #1305 #1306
standard-coverage-test removal mixing code coverage with MG, not clear why... contribution from devs who are not around anymore #1350 #1363
jds-do-not-panic-if-jdc-close-connection unit test this test is asserting internal architecture flow, not message flow between roles #1348 #1360
translation-proxy-old-share potential removal requires further investigation, we're not sure if "outdated" job_id is a sufficient criteria for rejecting shares

additionally, this test could potentially require a way to intercept/replace Sv1 messages (Sv1 Sniffer?), which could be a substantial engineering effort

so for now, I'd postpone (and potentially discard) this migration
#1560 #1561
pool-sri-test-extended_0 integration test #1474 #1354
pool-sri-test-extended_1 integration test #1475 #1354
interop-jdc-change-upstream integration test will help continue shaping #1122 #1207 #1486
jds-setupconnection-with-async-support removal the async flag of SetupConnection is being replaced via stratum-mining/sv2-spec#121, so this test should change strategy #1570 #1571
jds-setupconnection-without-async-support removal the async flag of SetupConnection is being replaced via stratum-mining/sv2-spec#121, so this test should change strategy #1570 #1571
pool-sri-test-1-standard integration test the JD mocking is meaningless #1476 #1540
jds-do-not-stackoverflow-when-no-token integration test #1503 #1505
translation-proxy-broke-pool removal test motivation is not clear

do we even want tProxy to shutdown just because pool sent a bad extranonce_prefix?

#1582
#1414 #1583
pool-sri-test-close-channel removal test motivation is not clear

do we even want tProxy to shutdown just because pool closed a channel?

#1582
#1414 #1583
interop-proxy-with-multi-ups-extended removal mining-proxy implementation is very problematic and not used anywhere, it's not worth trying to test it now #1557 #1590
interop-proxy-with-multi-ups removal mining-proxy implementation is very problematic and not used anywhere, it's not worth trying to test it now #1558 #1590
jds-receive-solution-while-processing-declared-job integration test #1419 #1581
sv1-test Sv1 Sniffer required #1565 #1580
jds-do-not-fail-on-wrong-tsdatasucc integration test #1566

Aside from the MG tests listed above, #1077 are also keeping track of some issues that are lacking CI and should eventually be covered by Integration Tests.

@plebhash plebhash added tracker Help us track a group of related issues ci/cd CI/CD integration-tests message-generator labels Oct 10, 2024
@plebhash plebhash changed the title CI migration: MG to Integration Tests CI migration: MG to Integration/Unit Tests Oct 10, 2024
@GitGab19 GitGab19 added this to the 1.2.0 milestone Oct 11, 2024
@GitGab19 GitGab19 modified the milestones: 1.2.0, 1.3.0 Dec 18, 2024
@GitGab19 GitGab19 moved this from Todo 📝 to In Progress 🏗️ in SV2 Roadmap 🛣️ Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd CI/CD integration-tests message-generator tracker Help us track a group of related issues
Projects
Status: In Progress 🏗️
Development

No branches or pull requests

2 participants