JDC Fallback test #1486

jbesraa · 2025-02-17T09:10:39Z

blocked by #1485
superseded #1343

codecov · 2025-02-17T09:13:11Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 18.97%. Comparing base (21fce41) to head (03011f2).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
roles/tests-integration/lib/mod.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1486   +/-   ##
=======================================
  Coverage   18.97%   18.97%           
=======================================
  Files         135      135           
  Lines        9466     9468    +2     
=======================================
+ Hits         1796     1797    +1     
- Misses       7670     7671    +1

Flag	Coverage Δ
binary_codec_sv2-coverage	`0.00% <ø> (ø)`
binary_sv2-coverage	`8.59% <ø> (ø)`
bip32_derivation-coverage	`0.00% <ø> (ø)`
buffer_sv2-coverage	`37.68% <ø> (ø)`
codec_sv2-coverage	`0.03% <ø> (ø)`
common_messages_sv2-coverage	`0.21% <ø> (ø)`
const_sv2-coverage	`0.00% <ø> (ø)`
error_handling-coverage	`0.00% <ø> (ø)`
framing_sv2-coverage	`0.45% <ø> (ø)`
jd_client-coverage	`0.44% <0.00%> (-0.01%)`	⬇️
jd_server-coverage	`14.46% <0.00%> (-0.04%)`	⬇️
job_declaration_sv2-coverage	`0.00% <ø> (ø)`
key-utils-coverage	`3.61% <ø> (ø)`
mining-coverage	`3.89% <ø> (+0.02%)`	⬆️
mining_device-coverage	`0.00% <0.00%> (ø)`
mining_proxy_sv2-coverage	`0.98% <0.00%> (-0.01%)`	⬇️
noise_sv2-coverage	`7.30% <ø> (ø)`
pool_sv2-coverage	`2.67% <0.00%> (-0.01%)`	⬇️
protocols	`27.17% <ø> (+0.02%)`	⬆️
roles	`6.83% <0.00%> (-0.01%)`	⬇️
roles_logic_sv2-coverage	`13.57% <ø> (ø)`
sv2_ffi-coverage	`0.00% <ø> (ø)`
template_distribution_sv2-coverage	`0.00% <ø> (ø)`
translator_sv2-coverage	`10.16% <0.00%> (-0.02%)`	⬇️
utils	`36.39% <ø> (ø)`
v1-coverage	`3.74% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roles/tests-integration/tests/jd_integration.rs

jbesraa · 2025-03-05T12:52:45Z

Super nice to see CI passing here!

This is ready for review btw.

jbesraa · 2025-03-06T09:05:46Z

This is ready for review

Shourya742

tested working fine:

roles/tests-integration/lib/mod.rs

roles/tests-integration/tests/jd_integration.rs

roles/tests-integration/tests/tproxy_jd_miner.rs

roles/tests-integration/lib/mod.rs

GitGab19 · 2025-03-12T09:01:16Z

Have we officially decided to add a file for every test?

I see that the tracker issue here is still opened without a final conclusion.

Maybe it's worth discussing this during the next PR Review Club call.

jbesraa · 2025-03-12T09:07:38Z

Have we officially decided to add a file for every test?

I see that the tracker issue here is still opened without a final conclusion.

Maybe it's worth discussing this during the next PR Review Club call.

Yea in one of the last calls we agreed that at least tests with a miner should be in a separate file.

plebhash · 2025-03-12T19:35:18Z

roles/tests-integration/tests/tproxy_jd_miner.rs

why is this file being added on this commit?

I understand the idea of separating tests with CPU miners, but:

this commit is titled "Allow start_jdc to accept multiple pool addresses", which doesn't have much to do with this specific change

we create this file but the test remains duplicated on translator_integration.rs

oops that was not intended

roles/test-utils/mining-device-sv1/src/client.rs

roles/tests-integration/tests/jdc_fallback.rs

roles/tests-integration/lib/mod.rs

roles/tests-integration/tests/jdc_fallback.rs

plebhash

ACK but looks like CI is broken

.. this timeout is used before switching pool's

.. otherwise it can go into an endless loop(which surprisingly did not happen until now..)

Add a test to validate the behavior of JDC upon receiving a SubmitShareError message from the connected Pool. JDC is expected to switch to a different pool/jds pair if specfied in the config, otherwise it should do solo mining. + Remove jdc-upstream-change MG test

jbesraa mentioned this pull request Feb 17, 2025

Test JDC Pool Fallback #1343

Closed

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch from 5b7bf18 to 54e53b5 Compare February 17, 2025 09:23

jbesraa commented Feb 17, 2025

View reviewed changes

roles/tests-integration/tests/jd_integration.rs Outdated Show resolved Hide resolved

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch from 54e53b5 to a5d299a Compare February 17, 2025 09:54

plebhash mentioned this pull request Mar 4, 2025

CI migration: MG to Integration/Unit Tests #1121

Open

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch 3 times, most recently from b3d0584 to e60addf Compare March 5, 2025 11:54

jbesraa marked this pull request as ready for review March 5, 2025 11:54

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch from e60addf to fee700d Compare March 6, 2025 07:05

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch 2 times, most recently from 4d572c0 to e51a71d Compare March 7, 2025 11:09

Shourya742 suggested changes Mar 7, 2025

View reviewed changes

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch 2 times, most recently from 73bb302 to b12e62c Compare March 7, 2025 11:51

Shourya742 suggested changes Mar 8, 2025

View reviewed changes

roles/tests-integration/lib/mod.rs Outdated Show resolved Hide resolved

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch 3 times, most recently from 8aa8719 to cfb256f Compare March 11, 2025 11:30

plebhash reviewed Mar 12, 2025

View reviewed changes

roles/test-utils/mining-device-sv1/src/client.rs Show resolved Hide resolved

plebhash reviewed Mar 12, 2025

View reviewed changes

roles/tests-integration/tests/jdc_fallback.rs Outdated Show resolved Hide resolved

plebhash reviewed Mar 12, 2025

View reviewed changes

roles/tests-integration/lib/mod.rs Outdated Show resolved Hide resolved

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch 2 times, most recently from 5cbb3a7 to 7c5febb Compare March 13, 2025 08:00

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch 3 times, most recently from b4352ba to 3d44c91 Compare March 13, 2025 09:45

plebhash reviewed Mar 13, 2025

View reviewed changes

roles/tests-integration/tests/jdc_fallback.rs Outdated Show resolved Hide resolved

plebhash reviewed Mar 13, 2025

View reviewed changes

roles/tests-integration/tests/jdc_fallback.rs Show resolved Hide resolved

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch from 3d44c91 to eb27cbe Compare March 14, 2025 15:52

plebhash approved these changes Mar 14, 2025

View reviewed changes

jbesraa added 4 commits March 14, 2025 19:14

Allow start_jdc to accept multiple (pool,jds) addresses

492a763

Fix JDC timeout config in tests

dd8240b

.. this timeout is used before switching pool's

Exit sv1 mining device if channel drops

d755b95

.. otherwise it can go into an endless loop(which surprisingly did not happen until now..)

jbesraa force-pushed the 2025-02-12/jdc-fallback-test branch from eb27cbe to 03011f2 Compare March 14, 2025 17:17

plebhash merged commit e60c6b2 into stratum-mining:main Mar 15, 2025
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDC Fallback test #1486

JDC Fallback test #1486

jbesraa commented Feb 17, 2025 •

edited by GitGab19

Loading

codecov bot commented Feb 17, 2025 •

edited

Loading

jbesraa commented Mar 5, 2025 •

edited

Loading

jbesraa commented Mar 6, 2025

Shourya742 left a comment

GitGab19 commented Mar 12, 2025

jbesraa commented Mar 12, 2025

plebhash Mar 12, 2025 •

edited

Loading

jbesraa Mar 13, 2025

plebhash left a comment •

edited

Loading

JDC Fallback test #1486

JDC Fallback test #1486

Conversation

jbesraa commented Feb 17, 2025 • edited by GitGab19 Loading

codecov bot commented Feb 17, 2025 • edited Loading

Codecov Report

jbesraa commented Mar 5, 2025 • edited Loading

jbesraa commented Mar 6, 2025

Shourya742 left a comment

Choose a reason for hiding this comment

GitGab19 commented Mar 12, 2025

jbesraa commented Mar 12, 2025

plebhash Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

jbesraa Mar 13, 2025

Choose a reason for hiding this comment

plebhash left a comment • edited Loading

Choose a reason for hiding this comment

jbesraa commented Feb 17, 2025 •

edited by GitGab19

Loading

codecov bot commented Feb 17, 2025 •

edited

Loading

jbesraa commented Mar 5, 2025 •

edited

Loading

plebhash Mar 12, 2025 •

edited

Loading

plebhash left a comment •

edited

Loading