Skip to content

Update phase1 settings #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Update phase1 settings #4190

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4707f4c
Update phase1 settings
sisuresh Feb 13, 2024
68ef929
Update state archival settings
sisuresh Feb 14, 2024
56d9036
Update fee settings
sisuresh Feb 14, 2024
c886305
update write fee
sisuresh Feb 14, 2024
8444386
Increase max write ledger entries to 25
sisuresh Feb 15, 2024
05d7f32
fix
sisuresh Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions soroban-settings/phase1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,8 @@
{
"state_archival": {
"max_entry_ttl": 3110400,
"min_temporary_ttl": 16,
"min_persistent_ttl": 120960,
"min_temporary_ttl": 17000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to do 17280 instead so we have exactly 24 hours?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number may have been chosen as a result of some calculation, so I'll defer to @dmkozh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17280 sounds fine to me - I just used a few rough numbers to compare the options.

Copy link
Contributor Author

@sisuresh sisuresh Feb 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 17280

"min_persistent_ttl": 2073600,
"persistent_rent_rate_denominator": 535680,
"temp_rent_rate_denominator": 5356800,
"max_entries_to_archive": 100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this new minimum TTL settings, we can update starting_eviction_scan_level to 7 since it is no longer possible for entries to expire in level 6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we reduce one of the ttl values below 16384, we should reduce the scan size as well right? Do you foresee any issues with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but this should be fine. We have a test that reduces the scan level and we've done this before on future net without issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Expand Down