Update phase1 settings #4190
Update phase1 settings #4190
Conversation
soroban-settings/phase1.json
Outdated
| @@ -295,8 +295,8 @@ | |||
| { | |||
| "state_archival": { | |||
| "max_entry_ttl": 3110400, | |||
| "min_temporary_ttl": 16, | |||
| "min_persistent_ttl": 120960, | |||
| "min_temporary_ttl": 17000, | |||
There was a problem hiding this comment.
Do we want to do 17280 instead so we have exactly 24 hours?
There was a problem hiding this comment.
This number may have been chosen as a result of some calculation, so I'll defer to @dmkozh.
There was a problem hiding this comment.
17280 sounds fine to me - I just used a few rough numbers to compare the options.
There was a problem hiding this comment.
Updated to 17280
| "min_temporary_ttl": 16, | ||
| "min_persistent_ttl": 120960, | ||
| "min_temporary_ttl": 17000, | ||
| "min_persistent_ttl": 2073600, | ||
| "persistent_rent_rate_denominator": 535680, | ||
| "temp_rent_rate_denominator": 5356800, | ||
| "max_entries_to_archive": 100, |
There was a problem hiding this comment.
With this new minimum TTL settings, we can update starting_eviction_scan_level to 7 since it is no longer possible for entries to expire in level 6.
There was a problem hiding this comment.
If we reduce one of the ttl values below 16384, we should reduce the scan size as well right? Do you foresee any issues with this?
There was a problem hiding this comment.
Correct, but this should be fine. We have a test that reduces the scan level and we've done this before on future net without issue.
|
It seems like we should now be able to use the values from https://docs.google.com/document/d/1RGFXy6gvzPUQwOtkcZrtvltjMBeqskwfZ__wcOCIXW8/edit#heading=h.ta18a689gwd4 |
soroban-settings/phase1.json
Outdated
| "tx_memory_limit": 41943040 | ||
| } | ||
| }, | ||
| { | ||
| "contract_ledger_cost_v0": { | ||
| "ledger_max_read_ledger_entries": 40, | ||
| "ledger_max_read_bytes": 133120, | ||
| "ledger_max_write_ledger_entries": 20, | ||
| "ledger_max_write_ledger_entries": 25, | ||
| "ledger_max_write_bytes": 66560, | ||
| "tx_max_read_ledger_entries": 40, | ||
| "tx_max_read_bytes": 133120, | ||
| "tx_max_write_ledger_entries": 20, |
There was a problem hiding this comment.
Also need to set this to 25
There was a problem hiding this comment.
Ah good catch. Fixed.
|
r+ 05d7f32 |
Description
Resolves #4186.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)