fix: Crash on uninitialized filterManager #6994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins Builds
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop status-im/status-desktop#6994 +/- ##
===========================================
+ Coverage 55.13% 59.42% +4.28%
===========================================
Files 820 821 +1
Lines 116624 116630 +6
===========================================
+ Hits 64301 69305 +5004
+ Misses 45535 40221 -5314
- Partials 6788 7104 +316
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Not sure if this will only hide the root cause because the proper flow on pairing is unknown to me. But from what I've seen Waku is only started after login. While `subscribe` and `unsubscribe` is used in the pairing flow as well.
alexjba
force-pushed
the
fix/crash-pairing-lightclient
branch
from
0bb63b6 to
8000720
Compare
osmaczko
approved these changes
Oct 14, 2025
Contributor
osmaczko
left a comment
osmaczko
left a comment
There was a problem hiding this comment.
Looks harmless, feel free to merge. I'll take it over then and provide a proper fix if needed.
igor-sirotin
approved these changes
Oct 14, 2025
Collaborator
igor-sirotin
left a comment
igor-sirotin
left a comment
There was a problem hiding this comment.
Let's merge for now and find the actual fix after 👍
I reproduced it with a functional test here: #7002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to get over this crash #7009. This is based on a superficial investigation to unblock other tasks and I'll merge it only if it's good enough. It's fixing the crash, the synced app seems fine.
Not sure if this will only hide the root cause because the proper flow on pairing is unknown to me. But from what I've seen Waku is only started after login. While
subscribeandunsubscribeis used in the pairing flow as well.