-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_storage: implement storage reader server with axum #10432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11-25-apollo_storage_add_appstate_struct_for_axum_server
Are you sure you want to change the base?
Conversation
|
Artifacts upload workflows: |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion
crates/apollo_storage/src/storage_reader_server.rs line 107 at r1 (raw file):
.route( "/storage/query", post(handle_request_endpoint::<RequestHandler, Request, Response>),
post or get?
Code quote:
post
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)
crates/apollo_storage/src/storage_reader_server.rs line 130 at r1 (raw file):
axum::Server::bind(&self.config.socket).serve(app.into_make_service()).await.map_err(|e| { error!("Storage reader server error: {}", e); StorageError::IOError(std::io::Error::other(e))
please avoid fully qualified paths
Code quote:
std::io::Error
No description provided.