Skip to content

Conversation

@nadin-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

Artifacts upload workflows:

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion


crates/apollo_storage/src/storage_reader_server.rs line 107 at r1 (raw file):

            .route(
                "/storage/query",
                post(handle_request_endpoint::<RequestHandler, Request, Response>),

post or get?

Code quote:

post

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)


crates/apollo_storage/src/storage_reader_server.rs line 130 at r1 (raw file):

        axum::Server::bind(&self.config.socket).serve(app.into_make_service()).await.map_err(|e| {
            error!("Storage reader server error: {}", e);
            StorageError::IOError(std::io::Error::other(e))

please avoid fully qualified paths

Code quote:

std::io::Error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants