apollo_storage: add AppState struct for axum server

[nadin-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-11-25T13:11:51Z
• Started at 2025-11-25T13:27:57Z
• Started at 2025-11-25T13:34:30Z
• Started at 2025-11-25T16:11:03Z
• Started at 2025-11-26T08:58:11Z

[nadin-Starkware]

• apollo_storage: implement storage reader server with axum #10432
• apollo_storage: add AppState struct for axum server #10407 👈 (View in Graphite)
• apollo_storage: add new fn for ServerConfig #10406
• apollo_class_manager_types: add storage request/response types #10400
• apollo_state_sync_types: add storage request/response types #10390
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

---

crates/apollo_storage/src/storage_reader_server.rs line 62 at r2 (raw file):

    storage_reader: Arc<StorageReader>,
    request_handler: Arc<RequestHandler>,
    semaphore: Arc<Semaphore>,

That's not needed in this context; please remove.

Code quote:

semaphore: Arc<Semaphore>,

[nadin-Starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_storage/src/storage_reader_server.rs line 62 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

That's not needed in this context; please remove.

Done.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions

---

crates/apollo_storage/src/storage_reader_server.rs line 57 at r3 (raw file):

    RequestHandler: StorageReaderServerHandler<Request, Response>,
{
    storage_reader: Arc<StorageReader>,

This is cloneable, so no need to wrap it in an arc
(I think internally it uses arc anyway)

Code quote:

StorageReader

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)

---

crates/apollo_storage/src/storage_reader_server.rs line 58 at r3 (raw file):

{
    storage_reader: Arc<StorageReader>,
    request_handler: Arc<RequestHandler>,

Any reason why RequestHandler wouldn't be Clone ? If not, please add it as a trait bound, and remove arc

Code quote:

Arc<RequestHandler>

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @nadin-Starkware)

---

crates/apollo_storage/src/storage_reader_server.rs line 84 at r3 (raw file):

    pub fn new(
        storage_reader: Arc<StorageReader>,
        request_handler: Arc<RequestHandler>,

Regardless of the changes above, can these be without arc, and wrapped internally?

Code quote:

        storage_reader: Arc<StorageReader>,
        request_handler: Arc<RequestHandler>,

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @nadin-Starkware)

---

crates/apollo_storage/Cargo.toml line 38 at r3 (raw file):

tempfile = { workspace = true, optional = true }
thiserror.workspace = true
tokio = { workspace = true, features = ["sync"] }

What requires this feature?

Code quote:

features = ["sync"]