apollo_gateway: move get_block_info to async #10060
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

TL;DR
Made
get_block_infoinMempoolStateReadertrait async to avoid blocking operations.What changed?
MempoolStateReadertrait to makeget_block_infoan async functionRpcStateReader,SyncStateReader, andTestStateReaderto be async#[async_trait]attribute to the trait and its implementationsRpcStateReader, moved the RPC request to aspawn_blockingtask to prevent blocking the async runtimeblock_oninSyncStateReaderin favor of proper async/await.awaitwhen callingget_block_infoHow to test?
Run the existing tests which have been updated to use the async version of
get_block_info:test_get_block_infoinrpc_state_reader_test.rstest_get_block_infoinsync_state_reader_test.rsWhy make this change?
This change improves the asynchronous behavior of the codebase by ensuring that potentially blocking operations like RPC requests don't block the async runtime. By making
get_block_infoasync, we can properly handle I/O operations without blocking threads, which leads to better resource utilization and scalability.